Upgrading a room to set it as restricted can be slow

[novocaine]

Steps to reproduce

Room settings -> Security and Privacy -> Access, set to spaces members for a room requiring an upgrade, then upgrade. Leave invite all members set enabled (the default).

This was for the Element Web Internal room.

What happened?

I had to wait 1-2 minutes for a loading spinner - if I didn't know better, I'd think things had broken and would have given up.

I expected it to not take this long, or if it does, show me some progress so I can see things are moving along.

Operating system

OS X

Browser information

Chrome

URL for webapp

develop.element.io

Homeserver

matrix.org

Have you submitted a rageshake?

No

[t3chguy]

So the upgrade process has a lot of work to do, especially if you choose to invite exiting users.

1. Upgrade the room itself (one slow API hit)
2. Wait for that room to come down /sync
3. Invite all users if user asked for it (default on) (one API hit per user)
4. Re-link the room into all parents where we can (two API hits per relationship)

[novocaine]

Can we show a progress meter..? @niquewoodhouse

[niquewoodhouse]

Can we show a progress meter..? @niquewoodhouse

Sure, sounds good to me if you're waiting around. We've got the progress bar we use on adding rooms to a space/migrating a community to a space. Using the same UI seems most reasonable to me.