Retain remoteusermedia modifications across sessions #3603
+88
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robintown
reviewed
Dec 3, 2025
Member
robintown
left a comment
robintown
left a comment
There was a problem hiding this comment.
I suspect this change makes it so that if you mute a participant, reload the page, and then try to unmute them by clicking the mute toggle, nothing happens. Storing both volume (reflects mute state) and committedVolume (non-zero, reflects the "unmuted" value) would be one way to fix this.
Contributor
|
@daniellekirkwood I think this need Product Input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3594
This adds a new settings type that is per-userId, that tracks settings you've applied to another user and retains them for the next call.
TODO: Need to think about per-userId+deviceId, as you probably only want this to apply to the specific device the user is using (at least for media controls)