Skip to content

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Nov 12, 2024

I think there is a race here where we might try to fetch reactions before the local state of the room has been synced, leading to missing hand raised reactions on newly joining clients to the room.

The easier solution here is to call fetchRelations on the client once we are ready, which will fetch any events in the case that we can't find the reaction we expect.

@toger5
Copy link
Contributor

toger5 commented Aug 4, 2025

This looks useful. What is missing to move it out of draft?
(Can the description get updated to explain the exact scenario in which this PR is needed. Iirc we might end up in the wrong toggle state if the related event is missing?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants