Skip to content

Conversation

@Johennes
Copy link
Contributor

@Johennes Johennes commented Nov 14, 2024

This implements MSC4156 which will ship with Matrix 1.12 and is the continuation of matrix-org/dendrite#3438.

Pull Request Checklist

Signed-off-by: Johannes Marbach [email protected]

@Johennes Johennes requested a review from a team as a code owner November 14, 2024 14:17
@CLAassistant
Copy link

CLAassistant commented Nov 14, 2024

CLA assistant check
All committers have signed the CLA.

@Johennes Johennes changed the title Johannes/msc4156 Add via parameter on join room requests as per MSC4156 #3438 Nov 14, 2024
@Johennes Johennes changed the title Add via parameter on join room requests as per MSC4156 #3438 Add via parameter on join room requests as per MSC4156 Nov 14, 2024
Copy link
Collaborator

@S7evinK S7evinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 49.40%. Comparing base (7cc7ebb) to head (f5e5396).

Files with missing lines Patch % Lines
clientapi/routing/joinroom.go 30.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3441      +/-   ##
==========================================
+ Coverage   49.36%   49.40%   +0.04%     
==========================================
  Files         522      522              
  Lines       59465    59472       +7     
==========================================
+ Hits        29353    29383      +30     
+ Misses      26647    26632      -15     
+ Partials     3465     3457       -8     
Flag Coverage Δ
unittests 49.40% <30.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK merged commit 7acf32f into element-hq:main Dec 9, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants