Skip to content

Conversation

@ppontes
Copy link
Member

@ppontes ppontes commented Apr 21, 2023

[M112] Stop supporting { handleEvent }.

Make the code aligned with the following specification update:
w3c/ServiceWorker#1676

With the previous specification and code, event listener vector
can be modified during the GetEffectiveFunction execution, which may
bring unexpected vector state.

(cherry picked from commit 5105ce37a6853d52ec97894bf6969b3c29a23afd)

Change-Id: I732c4c9ab2caebc49a7f4ef52640df7b8476d838
Bug: 1429201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4394402
Commit-Queue: Yoshisato Yanagisawa [email protected]
Reviewed-by: Kouhei Ueno [email protected]
Reviewed-by: Domenic Denicola [email protected]
Cr-Original-Commit-Position: refs/heads/main@{#1126483}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4408837
Reviewed-by: Shunya Shishido [email protected]
Reviewed-by: Minoru Chikamune [email protected]
Cr-Commit-Position: refs/branch-heads/5615@{#1203}
Cr-Branched-From: 9c6408ef696e83a9936b82bbead3d41c93c82ee4-refs/heads/main@{#1109224}

Ref electron/security#313

Notes: Security: backported fix for CVE-2023-2134.

@ppontes ppontes requested a review from a team as a code owner April 21, 2023 14:09
@ppontes ppontes added security 🔒 semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 23-x-y labels Apr 21, 2023
@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Apr 21, 2023
@ppontes ppontes marked this pull request as draft April 21, 2023 14:09
@ppontes ppontes force-pushed the cherry-pick/23-x-y/chromium/f58218891f8c branch from 2817ada to 64354ea Compare April 21, 2023 21:58
@ppontes ppontes marked this pull request as ready for review April 21, 2023 21:58
@ppontes ppontes marked this pull request as draft April 21, 2023 22:00
@ppontes ppontes force-pushed the cherry-pick/23-x-y/chromium/f58218891f8c branch from 64354ea to e6b6fb2 Compare April 21, 2023 22:02
@codebytere
Copy link
Member

Superseded by #38083

@codebytere codebytere closed this Apr 24, 2023
@codebytere codebytere deleted the cherry-pick/23-x-y/chromium/f58218891f8c branch April 24, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

23-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants