-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix handling of the custom protocol on windows #275
Conversation
This allows the defaultProtocolClient to work from |
@MarshallOfSound if electron/electron#8052 lands, would it render this PR unnecessary? |
Yep |
@zeke Actually a subsection of this PR is still required to make the protocol handler work from a non-packaged version of the app |
Just checking in here. @MarshallOfSound is this still something you want to ship eventually? |
Yeah, the PR in Electron needs to ship first though |
@MarshallOfSound are this and electron/electron#8052 still something that you want to land? If so, is there anything I can do to help unblock these two? |
@MarshallOfSound ping :D |
oh wait i lied, the other one landed so this is unnecessary |
Closing in favor of updated one. |
Fixes #271