Skip to content
This repository was archived by the owner on Dec 5, 2022. It is now read-only.

Conversation

MarshallOfSound
Copy link
Member

Fixes #271

@MarshallOfSound
Copy link
Member Author

This allows the defaultProtocolClient to work from npm start (so you don't need to be packaged for it to work). It also makes the alert appear on windows by handling the argv parameter in the makeSingleInstance callback

@zeke
Copy link
Contributor

zeke commented Nov 22, 2016

@MarshallOfSound if electron/electron#8052 lands, would it render this PR unnecessary?

@MarshallOfSound
Copy link
Member Author

Yep

@MarshallOfSound
Copy link
Member Author

@zeke Actually a subsection of this PR is still required to make the protocol handler work from a non-packaged version of the app

@zeke
Copy link
Contributor

zeke commented Mar 28, 2017

Just checking in here. @MarshallOfSound is this still something you want to ship eventually?

@MarshallOfSound
Copy link
Member Author

Yeah, the PR in Electron needs to ship first though

@ckerr
Copy link
Member

ckerr commented Feb 7, 2018

@MarshallOfSound are this and electron/electron#8052 still something that you want to land? If so, is there anything I can do to help unblock these two?

@ckerr
Copy link
Member

ckerr commented Mar 21, 2018

@MarshallOfSound ping :D

@codebytere
Copy link
Member

oh wait i lied, the other one landed so this is unnecessary

@codebytere
Copy link
Member

Closing in favor of updated one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants