-
Notifications
You must be signed in to change notification settings - Fork 47
chore: update playwright to 1.50.1 #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi folks, is there any blocker preventing the merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM
Due to the new headless mode, we need to tackle the release a bit differently. We can
- Release it without setting the
stack_version
tag to make sure we dont break the HB/Elastic Agent new images accidentally. - Build a new Elastic agent image with this new version and compare the previous runs with the current one to ensure the Performance metrics, duration all stays intact.
/cc @emilioalvap FYI
Based on a meeting we had recently, I think we agreed that updating & releasing synthetics with a newer playwright version will give us sometime to run Scout with more recent playwright/test and Chromium versions. Maybe it is feasible to update playwright to the most recent one 1.52.0? https://playwright.dev/docs/release-notes#version-152 |
@dmlemeshko We will run a few tests on our end and release a new version - for now we will merge and release as it is with |
Still running the performance comparison, for starters there's considerable change in size with the new headless version. Comparison of a snapshot build:
|
@shahzad31 @vigneshshanmugam everything working OK. So far the performance results are a bit conflicting, in some instances, the new chromium version seems to outperform the baseline while in others it routinely performs worse (around 10-15%): |
Thanks for testing @emilioalvap, Do we know the reason for the increase? Is it just merely coming from the new executables? |
@vigneshshanmugam Yes, there are now two separate chromium binaries for headless/headful: https://github.com/microsoft/playwright/blame/55333c6f285c017b54e97e6d86363baaeeb079c2/packages/playwright-chromium/install.js#L27 |
## Summary Updating playwright dependencies to the latest. Should be merged only after elastic/synthetics#999 --------- Co-authored-by: Shahzad <[email protected]> Co-authored-by: kibanamachine <[email protected]>
## Summary Updating playwright dependencies to the latest. Should be merged only after elastic/synthetics#999 --------- Co-authored-by: Shahzad <[email protected]> Co-authored-by: kibanamachine <[email protected]>
update playwright to 1.50.1 !!
1.49.0 Breaking changes !!
Breaking: channels chrome, msedge and similar switch to new headless
This change affects you if you're using one of the following channels in your playwright.config.ts:
chrome, chrome-dev, chrome-beta, or chrome-canary
msedge, msedge-dev, msedge-beta, or msedge-canary
What do I need to do?
After updating to Playwright v1.49, run your test suite. If it still passes, you're good to go. If not, you will probably need to update your snapshots, and adapt some of your test code around PDF viewers and extensions. See microsoft/playwright#33566 for more details.
Other breaking changes
There will be no more updates for WebKit on Ubuntu 20.04 and Debian 11. We recommend updating your OS to a later version.
Package @playwright/experimental-ct-vue2 will no longer be updated.
Package @playwright/experimental-ct-solid will no longer be updated.
1.50.0 Breaking changes !!
Breaking