Skip to content

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Feb 13, 2025

update playwright to 1.50.1 !!

1.49.0 Breaking changes !!

Breaking: channels chrome, msedge and similar switch to new headless
This change affects you if you're using one of the following channels in your playwright.config.ts:

chrome, chrome-dev, chrome-beta, or chrome-canary
msedge, msedge-dev, msedge-beta, or msedge-canary
What do I need to do?
After updating to Playwright v1.49, run your test suite. If it still passes, you're good to go. If not, you will probably need to update your snapshots, and adapt some of your test code around PDF viewers and extensions. See microsoft/playwright#33566 for more details.

Other breaking changes
There will be no more updates for WebKit on Ubuntu 20.04 and Debian 11. We recommend updating your OS to a later version.
Package @playwright/experimental-ct-vue2 will no longer be updated.
Package @playwright/experimental-ct-solid will no longer be updated.

1.50.0 Breaking changes !!

Breaking

  • expect(locator).toBeEditable() and locator.isEditable() now throw if the target element is not , , or a number of other editable elements. Option testConfig.updateSnapshots now updates all snapshots when set to all, rather than only the failed/changed snapshots. Use the new enum changed to keep the old functionality of only updating the changed snapshots.

@dmlemeshko
Copy link
Member

Hi folks, is there any blocker preventing the merge?

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

Due to the new headless mode, we need to tackle the release a bit differently. We can

  1. Release it without setting the stack_version tag to make sure we dont break the HB/Elastic Agent new images accidentally.
  2. Build a new Elastic agent image with this new version and compare the previous runs with the current one to ensure the Performance metrics, duration all stays intact.

/cc @emilioalvap FYI

@dmlemeshko
Copy link
Member

Based on a meeting we had recently, I think we agreed that updating & releasing synthetics with a newer playwright version will give us sometime to run Scout with more recent playwright/test and Chromium versions.

Maybe it is feasible to update playwright to the most recent one 1.52.0? https://playwright.dev/docs/release-notes#version-152

@vigneshshanmugam
Copy link
Member

@dmlemeshko We will run a few tests on our end and release a new version - for now we will merge and release as it is with 1.50.1 and do another by upgrading it to 1.52.0 just to be in the safer side.

@emilioalvap
Copy link
Contributor

Still running the performance comparison, for starters there's considerable change in size with the new headless version. Comparison of a snapshot build:

REPOSITORY         TAG       IMAGE ID       CREATED          SIZE
agent_synthetics   2.0.0     f55dd2ff38c1   32 minutes ago   3.92GB
agent_synthetics   1.0.1     505cad69678c   19 hours ago     3.37GB

@emilioalvap
Copy link
Contributor

emilioalvap commented May 14, 2025

@shahzad31 @vigneshshanmugam everything working OK. So far the performance results are a bit conflicting, in some instances, the new chromium version seems to outperform the baseline while in others it routinely performs worse (around 10-15%):
image
So far memory doesn't seem to be impacted that much:
image

@vigneshshanmugam
Copy link
Member

vigneshshanmugam commented May 19, 2025

Still running the performance comparison, for starters there's considerable change in size with the new headless version. Comparison of a snapshot build:

Thanks for testing @emilioalvap, Do we know the reason for the increase? Is it just merely coming from the new executables?

@emilioalvap
Copy link
Contributor

@shahzad31 shahzad31 merged commit 6b9878c into main May 19, 2025
11 checks passed
@shahzad31 shahzad31 deleted the update-playwright branch May 19, 2025 20:23
shahzad31 added a commit to elastic/kibana that referenced this pull request Jun 13, 2025
## Summary

Updating playwright dependencies to the latest. Should be merged only
after elastic/synthetics#999

---------

Co-authored-by: Shahzad <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
iblancof pushed a commit to iblancof/kibana that referenced this pull request Jun 16, 2025
## Summary

Updating playwright dependencies to the latest. Should be merged only
after elastic/synthetics#999

---------

Co-authored-by: Shahzad <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants