Skip to content

Conversation

@dadoonet
Copy link
Contributor

When using it, I have to "manually" cd back to the previous dir. I suggest that the instructions automatically cd back to the previous dir.

When using it, I have to "manually" cd back to the previous dir. 
I suggest that the instructions automatically cd back to the previous dir.
@ezimuel
Copy link
Collaborator

ezimuel commented Nov 26, 2025

@dadoonet the command that you updated is just an echo, it doesn't produce any effect. I don't think it's so relevant to add it as suggestion, the point is to inform users that they need to go inside the folder and execute the uninstall.sh script, that's it.
Maybe, I'm missing something? Thanks.

@dadoonet
Copy link
Contributor Author

Yes. It's just a "documentation" PR.

What the user is normally doing is something like:

curl -fsSL https://elastic.co/start-local | sh

But then you are getting this message:

I cannot proceed unless you uninstall it, using the following command:
cd elastic-start-local && ./uninstall.sh

So the user copy paste and run:

cd elastic-start-local && ./uninstall.sh

Then he goes to the history and run:

curl -fsSL https://elastic.co/start-local | sh

Which installs start-local in elastic-start-local/elastic-start-local.

Instead, if the user runs:

cd elastic-start-local && ./uninstall.sh && cd -
curl -fsSL https://elastic.co/start-local | sh

All would be good IMHO.

Again, minor change but because I hit this and did not really notice that I was not in the right "dir", I thought I'd propose a change.

@dadoonet
Copy link
Contributor Author

dadoonet commented Nov 26, 2025

Or may be we should have one of those commands:

curl -fsSL https://elastic.co/start-local | sh -s -- --uninstall
curl -fsSL https://elastic.co/start-local | sh -s -- --force

@ezimuel
Copy link
Collaborator

ezimuel commented Nov 26, 2025

Ok, I got it. Never do copy & paste 😄

@ezimuel ezimuel self-requested a review November 26, 2025 11:25
Copy link
Collaborator

@ezimuel ezimuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR.

@ezimuel ezimuel merged commit c156e23 into elastic:main Nov 26, 2025
7 checks passed
@dadoonet dadoonet deleted the cdback branch November 26, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants