-
Couldn't load subscription status.
- Fork 34
Add service.name field and drop_origin: true #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service.name field and drop_origin: true #24
Conversation
Signed-off-by: Tetiana Kravchenko <[email protected]>
Signed-off-by: Tetiana Kravchenko <[email protected]>
Signed-off-by: Tetiana Kravchenko <[email protected]>
Signed-off-by: Tetiana Kravchenko <[email protected]>
| - "k8s.pod.ip" | ||
| - "k8s.pod.uid" | ||
| - "k8s.pod.start_time" | ||
| - "k8s.container.name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not needed. Can you confirm?
I will also double check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the logs pipeline, this field will be provided by the filelog receiver container operator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Tetiana Kravchenko <[email protected]>
Signed-off-by: Tetiana Kravchenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Tetiana Kravchenko <[email protected]>
In this PR:
1.1. container with name:
prometheus-server- has a service.name :server- that is set from pod labels:1.2. rest of pods have k8s.container.name = service.name (screenshot above)
service.versionbased onapp.kubernetes.io/versionlabel (screenshot above)resource.attributes.app.label.componentandresource.attributes.app.label.versionelasticinframetricsprocessor