-
Notifications
You must be signed in to change notification settings - Fork 40
Align versions.yaml and tune release docs #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ChrsMark <[email protected]>
3. Bump up the `module-sets.edit-base.version` in `versions.yaml` i.e. from `v0.20.0` to `v0.21.0` | ||
(cross check latest version used by [EDOT](https://github.com/elastic/elastic-agent/blob/main/internal/pkg/otel/README.md?plain=1#L30), | ||
and https://github.com/elastic/opentelemetry-collector-components/tags) | ||
4. Set the tag for the following steps with `export $TAG=v0.21.0` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this step needed? I think the multimod + versions.yaml file are used to figure out the TAG value.
ssh-add <YOUR_SSH/GPG_KEY_PATH> | ||
make push-tags | ||
``` | ||
6. Create a repo level tag and push it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give more context on why we need a repo wide tag?
is automated and should not be performed manually unless there are specific reasons for this. | ||
|
||
1. (optional) Determine the version number that will be assigned to the release. It should | ||
match the latest upstream release version (`OTEL_VERSION`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIANM we decided to:
- not align to upstream, but instead bump the minor version each time we release
- release after each upstream release, and maybe also in between
Fixes #812
From now on we release all components horizontally on our own pace based on the
make push-tags
command and usingversions.yaml
as the source of truth. (based on #812 (comment))Docs have been updated accordingly.