Fix up DNS filter so it shows field/hostname/IP address on error #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso output error on SocketError, and show what's causing it and what the exact SocketError message is.
There was a problem hiding this comment.
btw, you can use structured logging now in logstash -
@logger.debug("DNS: couldn't resolve the hostname", :field => field, :hostname => event[field])
Don't worry about updating the patch, this is mainly just for future efforts :)
jordansissel
added a commit
that referenced
this pull request
Dec 21, 2011
Fix up DNS filter so it shows field/hostname/IP address on error
This was referenced Apr 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agreed on comments on previous pull request (sorry it took me so long to get this in): debug log will now output the field that the lookup failed on, the IP/hostname, and on SocketError, the entire error message.