-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Docs: Fix backticks in how to docs #11018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the "methods" sections of the how to develop a plugin docs Asciidoctor as incorrectly passing backticks into the output when it should have marked the words surrounded by backticks as code. I'm not 100% sure why it did that. The fix is to force macro evaluation immediately on attribute assignment.
karenzone
approved these changes
Aug 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
nik9000
added a commit
that referenced
this pull request
Aug 21, 2019
In the "methods" sections of the how to develop a plugin docs Asciidoctor as incorrectly passing backticks into the output when it should have marked the words surrounded by backticks as code. I'm not 100% sure why it did that. The fix is to force macro evaluation immediately on attribute assignment.
nik9000
added a commit
that referenced
this pull request
Aug 21, 2019
In the "methods" sections of the how to develop a plugin docs Asciidoctor as incorrectly passing backticks into the output when it should have marked the words surrounded by backticks as code. I'm not 100% sure why it did that. The fix is to force macro evaluation immediately on attribute assignment.
nik9000
added a commit
that referenced
this pull request
Aug 21, 2019
In the "methods" sections of the how to develop a plugin docs Asciidoctor as incorrectly passing backticks into the output when it should have marked the words surrounded by backticks as code. I'm not 100% sure why it did that. The fix is to force macro evaluation immediately on attribute assignment.
nik9000
added a commit
that referenced
this pull request
Aug 21, 2019
In the "methods" sections of the how to develop a plugin docs Asciidoctor as incorrectly passing backticks into the output when it should have marked the words surrounded by backticks as code. I'm not 100% sure why it did that. The fix is to force macro evaluation immediately on attribute assignment.
nik9000
added a commit
that referenced
this pull request
Aug 21, 2019
In the "methods" sections of the how to develop a plugin docs Asciidoctor as incorrectly passing backticks into the output when it should have marked the words surrounded by backticks as code. I'm not 100% sure why it did that. The fix is to force macro evaluation immediately on attribute assignment.
nik9000
added a commit
that referenced
this pull request
Aug 21, 2019
In the "methods" sections of the how to develop a plugin docs Asciidoctor as incorrectly passing backticks into the output when it should have marked the words surrounded by backticks as code. I'm not 100% sure why it did that. The fix is to force macro evaluation immediately on attribute assignment.
nik9000
added a commit
that referenced
this pull request
Aug 21, 2019
In the "methods" sections of the how to develop a plugin docs Asciidoctor as incorrectly passing backticks into the output when it should have marked the words surrounded by backticks as code. I'm not 100% sure why it did that. The fix is to force macro evaluation immediately on attribute assignment.
nik9000
added a commit
that referenced
this pull request
Aug 21, 2019
In the "methods" sections of the how to develop a plugin docs Asciidoctor as incorrectly passing backticks into the output when it should have marked the words surrounded by backticks as code. I'm not 100% sure why it did that. The fix is to force macro evaluation immediately on attribute assignment.
nik9000
added a commit
that referenced
this pull request
Aug 21, 2019
In the "methods" sections of the how to develop a plugin docs Asciidoctor as incorrectly passing backticks into the output when it should have marked the words surrounded by backticks as code. I'm not 100% sure why it did that. The fix is to force macro evaluation immediately on attribute assignment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the "methods" sections of the how to develop a plugin docs
Asciidoctor as incorrectly passing backticks into the output when it
should have marked the words surrounded by backticks as code. I'm not
100% sure why it did that. The fix is to force macro evaluation
immediately on attribute assignment.