Skip to content

VPR: Add branch attr to prevent broken links at 8.0 cutover #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented Jan 26, 2022

Plugin versioning is independent of Logstash/stack versioning. This PR sets (and then resets) an attribute to define a stack version that is appropriate for each particular version of the elasticsearch output plugin.

We updated the content source at v10.8.2 and removed the offending link. Therefore, the broken link isn't a problem beyond v10.8.1.

PREVIEW https://logstash-docs_1289.docs-preview.app.elstc.co/diff

@karenzone karenzone self-assigned this Jan 26, 2022
@karenzone karenzone changed the title VPR: Add branch attr to prevent bad links at 8.0 cutover VPR: Add branch attr to prevent broken links at 8.0 cutover Jan 26, 2022
@karenzone
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@karenzone karenzone force-pushed the 8.0-links branch 2 times, most recently from 892ff88 to 2311a31 Compare January 26, 2022 21:09
@karenzone karenzone marked this pull request as ready for review January 27, 2022 18:46
Copy link
Contributor Author

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds cleanly. Links resolve to an appropriate stack version rather than relying on current.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant