-
Notifications
You must be signed in to change notification settings - Fork 13
Support stack versions in versioned plugin docs. #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support stack versions in versioned plugin docs. #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a logical point, it seems correct to me.
Never seen the doc tooling, so I'm not able to foresee problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM w/ few minor nitpicks on style and reducing the need for extra checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview
Issue: #46
When customers visit versioned plugin reference pages and go through the links to stack versions, they will be always forwarded to
current
stack version documents. This leads confusion (example reported issue) and not guiding customers properly, example case.This PR suggests to add stack version to the VPR docs when new plugin releases happen so that we can easily use that version to forward the customers to proper stack version reference pages.
Closes #46
Test
mashhurs/doc-tools
. Then called inmashhurs/logstash-docs
VPR workflow.