This repository was archived by the owner on Jan 31, 2024. It is now read-only.
[elastic] Don't send the error messages to the client. #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add wrapper `NoDiagnosticsReply` to `jsonrpc2.Request.Reply`. Just call `NoDiagnosticsReply` for the handlers we used
zfy0701
reviewed
Aug 26, 2019
zfy0701
left a comment
zfy0701
left a comment
There was a problem hiding this comment.
the problem is not sending errors back to the client, the cost is low
it's more of a problem disabling diagnostic computation in the begining, if it is hard to do we could take time to analyze them later
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wrapper
NoDiagnosticsReplytojsonrpc2.Request.Reply. Just callNoDiagnosticsReplyfor the handlers we used