Skip to content

Expose FlushedMs metric in BulkIndexer #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

Expose FlushedMs metric in BulkIndexer #932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions esutil/bulk_indexer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ type BulkIndexerStats struct {
NumDeleted uint64
NumRequests uint64
FlushedBytes uint64
FlushedMs uint64
}

// BulkIndexerItem represents an indexer item.
Expand Down Expand Up @@ -276,6 +277,7 @@ type bulkIndexerStats struct {
numDeleted uint64
numRequests uint64
flushedBytes uint64
flushedMs uint64
}

// NewBulkIndexer creates a new bulk indexer.
Expand Down Expand Up @@ -365,6 +367,7 @@ func (bi *bulkIndexer) Stats() BulkIndexerStats {
NumDeleted: atomic.LoadUint64(&bi.stats.numDeleted),
NumRequests: atomic.LoadUint64(&bi.stats.numRequests),
FlushedBytes: atomic.LoadUint64(&bi.stats.flushedBytes),
FlushedMs: atomic.LoadUint64(&bi.stats.flushedMs),
}
}

Expand Down Expand Up @@ -568,6 +571,7 @@ func (w *worker) flushBuffer(ctx context.Context) error {
}
req.Header.Set(elasticsearch.HeaderClientMeta, "h=bp")

t := time.Now()
res, err := req.Do(ctx, w.bi.config.Client)
if err != nil {
atomic.AddUint64(&w.bi.stats.numFailed, uint64(len(w.items)))
Expand All @@ -576,6 +580,9 @@ func (w *worker) flushBuffer(ctx context.Context) error {
}
return fmt.Errorf("flush: %s", err)
}
elapsed := time.Since(t)
atomic.AddUint64(&w.bi.stats.flushedMs, uint64(elapsed.Milliseconds()))

if res.Body != nil {
defer res.Body.Close()
}
Expand Down