Skip to content

Enable tests failing due to java-joda warnings #42695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2019
Merged

Enable tests failing due to java-joda warnings #42695

merged 1 commit into from
May 31, 2019

Conversation

pgomulka
Copy link
Contributor

Tests were failing in mixed cluster after more broad warnings were
introduced in 6.x These tests were using yyyy-MM-dd pattern which
is now warning about the change of y to u. However, using predefined pattern
strict_date which uses the same format prevents the warning from being
generate and allow smooth upgrade/work in mixed cluster.
relates #42679

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
Enable tests failing due to java-joda warnings
902fa48 
Tests were failing in mixed cluster after more broad warnings were
introduced in 6.x These tests were using `yyyy-MM-dd` pattern which
is now warning about the change of `y` to `u`. However, using predefined pattern
`strict_date` which uses the same format prevents the warning from being
generate and allow smooth upgrade/work in mixed cluster.
relates elastic#42679
@pgomulka pgomulka added :Core/Infra/Core Core issues without another label >test-failure Triaged test failures from CI labels May 30, 2019
@pgomulka pgomulka self-assigned this May 30, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

rjernst
rjernst approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka requested a review from jbaiera May 30, 2019 19:55
@pgomulka pgomulka merged commit 6bd4e8c into elastic:7.2 May 31, 2019
@pgomulka pgomulka mentioned this pull request May 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjernst rjernst rjernst approved these changes

@jbaiera jbaiera Awaiting requested review from jbaiera

Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgomulka @elasticmachine @rjernst