Adds ability to update a policy #31361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colings86
added
review
:Data Management/ILM+SLM
|
Pinging @elastic/es-core-infra |
talevy
reviewed
Jun 19, 2018
There was a problem hiding this comment.
it may be helpful to add javadocs to these, at least for the final version
|
Overall LGTM, will wait for merge with index-lifecycle and give it another look |
jasontedor
pushed a commit
that referenced
this pull request
Aug 17, 2018
* Adds ability to update a policy as long as no indexes are in the shrink action * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will work as long as no indexes are in the shrink action action