-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Move ES|QL score function out of snapshot #133208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔍 Preview links for changed docs |
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to re-run the ScoreTests
to regenerate the docs files?
Thinking primarily if we need to update the function specification for Kibana.
* [`MATCH`](../../functions-operators/search-functions.md#esql-match) | ||
* [`MATCH_PHRASE`](../../functions-operators/search-functions.md#esql-match_phrase) | ||
* [`QSTR`](../../functions-operators/search-functions.md#esql-qstr) | ||
* [`SCORE`](../../functions-operators/search-functions.md#esql-score) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's add the preview label here since it's tech preview.
it would be inline with what we have in the FunctionInfo
already:
Lines 46 to 48 in e091235
@FunctionInfo( | |
returnType = "double", | |
preview = true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to re-run the ScoreTests to regenerate the docs files?
I re-run them but there're no change made to the docs for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I already see "snapshot_only" : false
in the Kibana spec, so I think we're done.
we should wait for the shard available bug to be fixed before merging this one. |
we need to fix #133462 before moving this out of snapshot |
This exposes the
SCORE
function in ES|QL out of snapshot (tech preview).SCORE
function can only be used on the right hand side of anEVAL
to explicitly put scores of a (combination of) full text functions into a specific column (different than_score
).