Take match_phrase out of snapshot and make tech preview #128925

kderusso · 2025-06-04T18:54:10Z

Takes the match_phrase function out of snapshot and releases it as technical preview

elasticsearchmachine · 2025-06-04T18:54:35Z

Pinging @elastic/es-analytical-engine (Team:Analytics)

elasticsearchmachine · 2025-06-04T18:54:35Z

Hi @kderusso, I've created a changelog YAML for you.

elasticsearchmachine · 2025-06-04T18:55:07Z

Pinging @elastic/search-eng (Team:SearchOrg)

elasticsearchmachine · 2025-06-04T18:55:08Z

Pinging @elastic/search-relevance (Team:Search - Relevance)

carlosdelest

LGTM!

You should remove the guards that depend on EsqlCapabilities.Cap. MATCH_PHRASE_FUNCTION - the ones used on tests like VerifierTests and MatchPhraseTests, as they are no longer necessary

docs/changelog/128925.yaml

ioanatia

the docs are not correctly generated, I think we need to change this:

elasticsearch/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/MatchPhrase.java

Line 97 in 3721613

    
                       Use `MATCH_PHRASE` to perform a <<query-dsl-match-query-phrase,match_phrase query>> on the specified field.

and point to [`match_phrase`](/reference/query-languages/query-dsl/query-dsl-match-query-phrase.md) instead.

...c/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/FullTextWritables.java

Co-authored-by: Carlos Delgado <[email protected]>

kderusso · 2025-06-06T12:33:31Z

@ioanatia per:

the docs are not correctly generated, I think we need to change this:

elasticsearch/x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/MatchPhrase.java

Line 97 in 3721613
         Use `MATCH_PHRASE` to perform a <<query-dsl-match-query-phrase,match_phrase query>> on the specified field. 
and point to match_phrase instead.

I think there's something still weird with the docs build here, any ideas?

…uild

elasticsearchmachine · 2025-06-09T16:57:31Z

💔 Backport failed

Status	Branch	Result
❌	8.19	Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 128925

* Take match_phrase out of snapshot and make tech preview * Update docs/changelog/128925.yaml * PR feedback * Adding regenerated test data * Update docs/changelog/128925.yaml Co-authored-by: Carlos Delgado <[email protected]> * [CI] Auto commit changes from spotless * Checkstyle * Correct docs * Hopefully fix docs build * Found one more bad docs link - here's hoping this now fixes the doc build * OMG bitten by - vs _ --------- Co-authored-by: Carlos Delgado <[email protected]> Co-authored-by: elasticsearchmachine <[email protected]> Co-authored-by: Aurélien FOUCRET <[email protected]>

kderusso · 2025-06-10T19:28:39Z

Backport PR: #129215

* Take match_phrase out of snapshot and make tech preview * Update docs/changelog/128925.yaml * PR feedback * Adding regenerated test data * Update docs/changelog/128925.yaml Co-authored-by: Carlos Delgado <[email protected]> * [CI] Auto commit changes from spotless * Checkstyle * Correct docs * Hopefully fix docs build * Found one more bad docs link - here's hoping this now fixes the doc build * OMG bitten by - vs _ --------- Co-authored-by: Carlos Delgado <[email protected]> Co-authored-by: elasticsearchmachine <[email protected]> Co-authored-by: Aurélien FOUCRET <[email protected]>

* [ES|QL] Add MATCH_PHRASE (#127661) * Initial commit of match_phrase * Add MatchPhraseQueryTests * First pass at CSV specs * Update docs/changelog/127661.yaml * Refactor so MatchPhrase doesn't use all fulltext test cases, just text only * Fix tests * Add some CSV test cases * Fix test * Update changelog * Update tests * Comment out MATCH_PHRASE in search-functions Markdown * Minor PR feedback * PR feedback - refactor/consolidate code * Add some more tests * Fix some tests * [CI] Auto commit changes from spotless * Fix tests * PR feedback - add tests, support boost and numeric data * Revert "PR feedback - add tests, support boost and numeric data" This reverts commit 4e7a699. * Apply testing/PR feedback outside numeric support only * Regenerate docs * Add negative test * Update x-pack/plugin/esql/qa/testFixtures/src/main/resources/match-phrase-function.csv-spec Co-authored-by: Carlos Delgado <[email protected]> * Update x-pack/plugin/esql/qa/testFixtures/src/main/resources/match-phrase-function.csv-spec Co-authored-by: Carlos Delgado <[email protected]> * Update x-pack/plugin/esql/qa/testFixtures/src/main/resources/match-phrase-function.csv-spec Co-authored-by: Carlos Delgado <[email protected]> * PR feedback * Fix auto-commit error * Regenerate docs * Update x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/MatchPhrase.java Co-authored-by: Liam Thompson <[email protected]> * Remove non text field types * Fake test data * Remove tests that no longer should pass without ip/date/version support * Put real data in score tests now that I was able to engineer a failure * Realized the scoring test might be flakey because how it was written, updated * PR feedback * PR feedback * [CI] Auto commit changes from spotless * Add check to MatchPhrase tests * Fix merge errors * [CI] Auto commit changes from spotless * Test generated docs * Add additional verifier tests --------- Co-authored-by: elasticsearchmachine <[email protected]> Co-authored-by: Carlos Delgado <[email protected]> Co-authored-by: Liam Thompson <[email protected]> (cherry picked from commit eee423a) # Conflicts: # docs/reference/esql/functions/description/match_phrase.md # docs/reference/esql/functions/examples/match_phrase.md # docs/reference/esql/functions/kibana/definition/match_phrase.json # docs/reference/esql/functions/kibana/docs/match_phrase.md # docs/reference/query-languages/esql/_snippets/lists/search-functions.md # docs/reference/query-languages/esql/functions-operators/search-functions.md # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/EsqlFunctionRegistry.java # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/FullTextFunction.java # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/Match.java # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/QueryString.java # x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java * Take match_phrase out of snapshot and make tech preview (#128925) * Take match_phrase out of snapshot and make tech preview * Update docs/changelog/128925.yaml * PR feedback * Adding regenerated test data * Update docs/changelog/128925.yaml Co-authored-by: Carlos Delgado <[email protected]> * [CI] Auto commit changes from spotless * Checkstyle * Correct docs * Hopefully fix docs build * Found one more bad docs link - here's hoping this now fixes the doc build * OMG bitten by - vs _ --------- Co-authored-by: Carlos Delgado <[email protected]> Co-authored-by: elasticsearchmachine <[email protected]> Co-authored-by: Aurélien FOUCRET <[email protected]> * Remove null example for match_phrase (#129173) * Fix errors from merge * Fix more errors from merge * [CI] Auto commit changes from spotless * Fix compile errors introduced through cherry-pick * Fix test compilation * Generate docs * Register match_phrase as a function not a snapshot function (#129255) * Register match_phrase as a function not a snapshot function * Update usage * Fix usage --------- Co-authored-by: Carlos Delgado <[email protected]> Co-authored-by: elasticsearchmachine <[email protected]> Co-authored-by: Aurélien FOUCRET <[email protected]> Co-authored-by: Ioana Tagirta <[email protected]>

Take match_phrase out of snapshot and make tech preview

2a4dcee

kderusso added >enhancement auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v8.19.0 v9.1.0 labels Jun 4, 2025

elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 4, 2025

Update docs/changelog/128925.yaml

37afbca

kderusso added the :SearchOrg/Relevance Label for the Search (solution/org) Relevance team label Jun 4, 2025

kderusso requested review from afoucret, carlosdelest and ioanatia June 4, 2025 18:55

elasticsearchmachine added Team:SearchOrg Meta label for the Search Org (Enterprise Search) Team:Search - Relevance The Search organization Search Relevance team labels Jun 4, 2025

carlosdelest approved these changes Jun 5, 2025

View reviewed changes

docs/changelog/128925.yaml Outdated Show resolved Hide resolved

ioanatia reviewed Jun 5, 2025

View reviewed changes

...c/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/FullTextWritables.java Show resolved Hide resolved

kderusso and others added 9 commits June 5, 2025 09:05

PR feedback

404a2be

Adding regenerated test data

fecb0c3

Update docs/changelog/128925.yaml

6c6eea3

Co-authored-by: Carlos Delgado <[email protected]>

[CI] Auto commit changes from spotless

476054d

Merge branch 'main' into kderusso/esql-match-phrase-tech-preview

f6a6d87

Checkstyle

8325245

Merge branch 'main' into kderusso/esql-match-phrase-tech-preview

20d67fa

Merge branch 'main' into kderusso/esql-match-phrase-tech-preview

ec94c06

Merge branch 'main' into kderusso/esql-match-phrase-tech-preview

d3acfe2

kderusso added 5 commits June 9, 2025 09:25

Correct docs

2b9fc30

Hopefully fix docs build

0f68d80

Found one more bad docs link - here's hoping this now fixes the doc b…

26e1249

…uild

Merge branch 'main' into kderusso/esql-match-phrase-tech-preview

0bc52fc

OMG bitten by - vs _

278de28

kderusso enabled auto-merge (squash) June 9, 2025 15:50

kderusso merged commit b214fbf into elastic:main Jun 9, 2025
16 of 18 checks passed

elasticsearchmachine added the backport pending label Jun 9, 2025

kderusso mentioned this pull request Jun 10, 2025

[8.19] [ES|QL] Add MATCH_PHRASE (#127661) #129215

Merged

kderusso mentioned this pull request Jun 11, 2025

Register match_phrase as a function not a snapshot function #129255

Merged

kderusso removed the backport pending label Jun 12, 2025

carlosdelest mentioned this pull request Jun 16, 2025

ES|QL: Add support for match_phrase #125012

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Take match_phrase out of snapshot and make tech preview #128925

Take match_phrase out of snapshot and make tech preview #128925

Uh oh!

kderusso commented Jun 4, 2025

Uh oh!

elasticsearchmachine commented Jun 4, 2025

Uh oh!

elasticsearchmachine commented Jun 4, 2025

Uh oh!

elasticsearchmachine commented Jun 4, 2025

Uh oh!

elasticsearchmachine commented Jun 4, 2025

Uh oh!

carlosdelest left a comment

Uh oh!

Uh oh!

ioanatia left a comment •

edited

Loading

Uh oh!

Uh oh!

kderusso commented Jun 6, 2025

Uh oh!

Uh oh!

elasticsearchmachine commented Jun 9, 2025

Uh oh!

kderusso commented Jun 10, 2025

Uh oh!

Uh oh!

Take match_phrase out of snapshot and make tech preview #128925

Take match_phrase out of snapshot and make tech preview #128925

Uh oh!

Conversation

kderusso commented Jun 4, 2025

Uh oh!

elasticsearchmachine commented Jun 4, 2025

Uh oh!

elasticsearchmachine commented Jun 4, 2025

Uh oh!

elasticsearchmachine commented Jun 4, 2025

Uh oh!

elasticsearchmachine commented Jun 4, 2025

Uh oh!

carlosdelest left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ioanatia left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kderusso commented Jun 6, 2025

Uh oh!

Uh oh!

elasticsearchmachine commented Jun 9, 2025

💔 Backport failed

Uh oh!

kderusso commented Jun 10, 2025

Uh oh!

Uh oh!

ioanatia left a comment •

edited

Loading