Skip to content

Conversation

benwtrent
Copy link
Member

this is a low level query for some basic IVF querying logic. Right now its the simple, just hit ever segment and search. But we needed to fork away from the typical kNN query due to all the logic there around dropping to exact search for filtered search, etc.

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label May 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label May 8, 2025
@elasticsearchmachine elasticsearchmachine merged commit a7a430f into elastic:main May 8, 2025
17 checks passed
@benwtrent benwtrent deleted the ivf-knn-query branch May 8, 2025 15:33
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request May 9, 2025
this is a low level query for some basic IVF querying logic. Right now
its the simple, just hit ever segment and search. But we needed to fork
away from the typical kNN query due to all the logic there around
dropping to exact search for filtered search, etc.
john-wagster added a commit that referenced this pull request May 9, 2025
john-wagster added a commit that referenced this pull request May 9, 2025
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request May 12, 2025
this is a low level query for some basic IVF querying logic. Right now
its the simple, just hit ever segment and search. But we needed to fork
away from the typical kNN query due to all the logic there around
dropping to exact search for filtered search, etc.
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request May 12, 2025
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request May 13, 2025
benwtrent added a commit that referenced this pull request May 14, 2025
…128052)

* Reapply "Adds unused lower level ivf knn query (#127852)" (#128003)

This reverts commit 648d74b.

* Fixing tests
richard-dennehy pushed a commit to richard-dennehy/elasticsearch that referenced this pull request May 19, 2025
…stic#128003) (elastic#128052)

* Reapply "Adds unused lower level ivf knn query (elastic#127852)" (elastic#128003)

This reverts commit 648d74b.

* Fixing tests
benchaplin pushed a commit to benchaplin/elasticsearch that referenced this pull request May 20, 2025
…stic#128003) (elastic#128052)

* Reapply "Adds unused lower level ivf knn query (elastic#127852)" (elastic#128003)

This reverts commit 648d74b.

* Fixing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants