-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Adds unused lower level ivf knn query #127852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
tteofili
approved these changes
May 8, 2025
john-wagster
approved these changes
May 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
this is a low level query for some basic IVF querying logic. Right now its the simple, just hit ever segment and search. But we needed to fork away from the typical kNN query due to all the logic there around dropping to exact search for filtered search, etc.
john-wagster
added a commit
that referenced
this pull request
May 9, 2025
This reverts commit a7a430f.
john-wagster
added a commit
that referenced
this pull request
May 9, 2025
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
this is a low level query for some basic IVF querying logic. Right now its the simple, just hit ever segment and search. But we needed to fork away from the typical kNN query due to all the logic there around dropping to exact search for filtered search, etc.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
…tic#128003) This reverts commit a7a430f.
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
May 13, 2025
…stic#128003) This reverts commit 648d74b.
richard-dennehy
pushed a commit
to richard-dennehy/elasticsearch
that referenced
this pull request
May 19, 2025
…stic#128003) (elastic#128052) * Reapply "Adds unused lower level ivf knn query (elastic#127852)" (elastic#128003) This reverts commit 648d74b. * Fixing tests
benchaplin
pushed a commit
to benchaplin/elasticsearch
that referenced
this pull request
May 20, 2025
…stic#128003) (elastic#128052) * Reapply "Adds unused lower level ivf knn query (elastic#127852)" (elastic#128003) This reverts commit 648d74b. * Fixing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
>non-issue
:Search Relevance/Vectors
Vector search
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a low level query for some basic IVF querying logic. Right now its the simple, just hit ever segment and search. But we needed to fork away from the typical kNN query due to all the logic there around dropping to exact search for filtered search, etc.