retain the scores of portions of an ES|QL query, via a score function #127551

tteofili · 2025-04-30T09:26:45Z

this is a first attempt to retain the score of single portions of an ES|QL query.
this one does it via a score function.

  FROM test METADATA _score
  | WHERE match(content, "brown")
  | WHERE match(content, "fox")
  | EVAL first_score = score(match(content, "brown"))
  | KEEP id, _score, first_score
  | SORT id

this should work with all (boolean combinations of) full text functions

fixes #120082

…edqueries

… into esql_namedqueries

…edqueries

… into esql_namedqueries

…edqueries

ioanatia

We need to add the files that are generated for docs, even if the function is under snapshot.
See #127322 where knn is under snapshot but we still include all the doc files.

...rc/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/FullTextFunction.java

x-pack/plugin/esql/qa/testFixtures/src/main/resources/score-function.csv-spec

...ugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/Score.java

…edqueries

… into esql_namedqueries

carlosdelest

Almost there!

We're missing the AbstractFunctionTestCase as was mentioned - one question about usage in WHERE.

...rc/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/FullTextFunction.java

…edqueries

github-actions · 2025-07-14T15:45:34Z

🔍 Preview links for changed docs

docs/reference/query-languages/esql/kibana/docs/functions/score.md

carlosdelest

LGTM 👍

This is behind snapshot so we can iterate on this if needed for lifting restrictions etc.

...ugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/Score.java

…expression/function/fulltext/Score.java Co-authored-by: Carlos Delgado <[email protected]>

…elastic#127551)

tteofili added 4 commits April 11, 2025 11:33

Merge

77101fc

Merge branch 'main' of github.com:elastic/elasticsearch into esql_nam…

819b364

…edqueries

first chicken_score PoC

e2f774d

Merge branch 'main' of github.com:elastic/elasticsearch into esql_nam…

457aebe

…edqueries

elasticsearchmachine added the v9.1.0 label Apr 30, 2025

tteofili and others added 18 commits April 30, 2025 11:30

first chicken_score PoC

494f95e

[CI] Auto commit changes from spotless

8f38eb3

more tests, minor fixes

701fe46

minor test fixes

0ed4f70

Merge branch 'esql_namedqueries' of github.com:tteofili/elasticsearch…

bab8a4b

… into esql_namedqueries

spotless

9e78a73

improved tests

ddb40cd

[CI] Auto commit changes from spotless

d1e2f1a

Merge branch 'main' of github.com:elastic/elasticsearch into esql_nam…

5ba09df

…edqueries

missing readFrom

ec3b05a

Merge branch 'main' of github.com:elastic/elasticsearch into esql_nam…

59ec292

…edqueries

missing function wiring

d0c17a4

Merge branch 'esql_namedqueries' of github.com:tteofili/elasticsearch…

b8001af

… into esql_namedqueries

[CI] Auto commit changes from spotless

d6b2649

chicken_score --> score, fixed FTF checks and namedwritable reading

6944207

Merge branch 'esql_namedqueries' of github.com:tteofili/elasticsearch…

880ec89

… into esql_namedqueries

spotless

994c9de

Merge branch 'main' of github.com:elastic/elasticsearch into esql_nam…

522bdfb

…edqueries

tteofili changed the title ~~named queries support for ES|QL via chicken_score function~~ named queries support for ES|QL via a score function May 22, 2025

tteofili added 2 commits May 22, 2025 14:48

minor test fix

e8229e1

more tests

2edaef8

tteofili changed the title ~~named queries support for ES|QL via a score function~~ retain the scores of portions of ES|QL query, via a score function May 22, 2025

tteofili changed the title ~~retain the scores of portions of ES|QL query, via a score function~~ retain the scores of portions of an ES|QL query, via a score function May 22, 2025

tteofili added 2 commits May 22, 2025 15:09

Merge branch 'main' of github.com:elastic/elasticsearch into esql_nam…

a15844d

…edqueries

slightly better FTF check for EVAL s = score(...)

f0d3b76

dropped test

d121042

ioanatia reviewed Jul 7, 2025

View reviewed changes

tteofili and others added 12 commits July 10, 2025 11:52

Merge branch 'main' of github.com:elastic/elasticsearch into esql_nam…

6060f84

…edqueries

improved checks and tests

10edc05

Merge branch 'main' of github.com:elastic/elasticsearch into esql_nam…

0d7ecd1

…edqueries

[CI] Auto commit changes from spotless

afc1287

check score is always used before limit, aggs, etc.

f0cd402

Merge branch 'esql_namedqueries' of github.com:tteofili/elasticsearch…

eb14196

… into esql_namedqueries

spotless

b964313

non pushable disjunction csv test

f4dfa0a

minor fix

88997d9

minor fix

97822b3

minor fix

86287a9

minor fix

852fb22

carlosdelest reviewed Jul 14, 2025

View reviewed changes

...rc/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/FullTextFunction.java Show resolved Hide resolved

tteofili added 2 commits July 14, 2025 10:57

Merge branch 'main' of github.com:elastic/elasticsearch into esql_nam…

c941ea7

…edqueries

ScoreTests and docs

e888da2

revert

398aa7c

carlosdelest approved these changes Jul 15, 2025

View reviewed changes

...ugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/Score.java Outdated Show resolved Hide resolved

tteofili and others added 4 commits July 15, 2025 09:23

Update x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/…

18df6f0

…expression/function/fulltext/Score.java Co-authored-by: Carlos Delgado <[email protected]>

Merge branch 'main' into esql_namedqueries

87bce59

[CI] Auto commit changes from spotless

c0e6258

Merge branch 'main' into esql_namedqueries

c852c81

ioanatia approved these changes Jul 15, 2025

View reviewed changes

tteofili merged commit fd037bd into elastic:main Jul 15, 2025
32 of 33 checks passed

This was referenced Jul 16, 2025

[CI] VerifierTests testFullTextFunctionsOnlyAllowedInWhere failing #131335

Closed

[CI] VerifierTests testMatchInsideEval failing #131336

Closed

mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025

retain the scores of portions of an ES|QL query, via a score function (…

463b720

…elastic#127551)

mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025

retain the scores of portions of an ES|QL query, via a score function (…

fafaec2

…elastic#127551)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

retain the scores of portions of an ES|QL query, via a score function #127551

retain the scores of portions of an ES|QL query, via a score function #127551

Uh oh!

tteofili commented Apr 30, 2025 •

edited

Loading

Uh oh!

ioanatia left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carlosdelest left a comment

Uh oh!

Uh oh!

github-actions bot commented Jul 14, 2025 •

edited

Loading

Uh oh!

carlosdelest left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

retain the scores of portions of an ES|QL query, via a score function #127551

retain the scores of portions of an ES|QL query, via a score function #127551

Uh oh!

Conversation

tteofili commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ioanatia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carlosdelest left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 Preview links for changed docs

Uh oh!

carlosdelest left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tteofili commented Apr 30, 2025 •

edited

Loading

github-actions bot commented Jul 14, 2025 •

edited

Loading