[TEST] Remove flaky checks on snapshot shard stats #123458
Conversation
kkrik-es
added
>test
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
| - match: { snapshot.snapshot: test_snapshot_2 } | ||
| - match: { snapshot.state : PARTIAL } | ||
| - match: { snapshot.shards.successful: 0 } | ||
| - match: { snapshot.shards.failed : 1 } |
There was a problem hiding this comment.
It is strange that that .security index is included. In both create snapshot requests, indices parameter is specified and the pattern doesn't match with the security index.
There was a problem hiding this comment.
I think the reason system indices are included is because include_global_state defaults to true. I think we just need to set include_global_state to false in the create snapshot request and that should resolve the test failure as well and then we can keep these assertions.
There was a problem hiding this comment.
FWIW I think this is a more fundamental bug, we should be calling the reset-feature-state API to clean up system indices between tests, but it seems that the .security index is escaping that cleanup. I mean this is an ok fix assuming you don't really need these assertions, but there's definitely something bad happening here.
There was a problem hiding this comment.
Right we actually kept the asserts and applied "include_global_state": false. That should do the trick, let's see.
There was a problem hiding this comment.
++ sorry yeah also a valid workaround, but still there's some more fundamental problem here.
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* Update 10_basic.yml * Update muted-tests.yml * Update 10_basic.yml (cherry picked from commit 4269c73) # Conflicts: # muted-tests.yml
* Update 10_basic.yml * Update muted-tests.yml * Update 10_basic.yml (cherry picked from commit 4269c73)
4 participants
Snapshot shard statistics seem to pick up unrelated files, leading to flakiness.
Fixes #120332