Skip to content

Adds external link to execute watch API and removes request examples #4634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2025

Conversation

kosabogi
Copy link
Contributor

DO NOT MERGE BEFORE elastic/docs-content#1780

This PR adds an external link to the Execute a watch API and removes unnecessary/redundant Request examples.

Related issue: https://github.com/elastic/docs-projects/issues/302

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
watcher.execute_watch 🟢 7/7 7/7

You can validate these APIs yourself by using the make validate target.

@kosabogi kosabogi requested a review from szabosteve June 23, 2025 07:34
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so good, I'm gonna approve it instead of commenting 😄

@kosabogi kosabogi merged commit 0ef8855 into main Jun 23, 2025
8 checks passed
@kosabogi kosabogi deleted the execute-watch branch June 23, 2025 08:49
Copy link
Contributor

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-4634-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0ef8855d679f070ea18c6b14b243895ea349f3c5
# Push it to GitHub
git push --set-upstream origin backport-4634-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-4634-to-9.0.

kosabogi added a commit that referenced this pull request Jun 23, 2025
…4634)

* Adds external link to execute watch API and removes request examples

* Adds external doc id to table.csv

(cherry picked from commit 0ef8855)
kosabogi added a commit that referenced this pull request Jun 23, 2025
…4634)

* Adds external link to execute watch API and removes request examples

* Adds external doc id to table.csv

(cherry picked from commit 0ef8855)
kosabogi added a commit that referenced this pull request Jun 24, 2025
…quest examples (#4647)

* Adds external link to execute watch API and removes request examples (#4634)

* Adds external link to execute watch API and removes request examples

* Adds external doc id to table.csv

(cherry picked from commit 0ef8855)

* Adds execute-watch to table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants