Update dependency to explicitly support version 7 #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency has been updated to follow Elasticsearch gems' version policy. This improves gem consistency and maintenance efficiency.
|
Thanks for this contribution @aeroastro! You're absolutely right 👍 |
|
Thank you ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating a patch for #980, I have found out the currently supported
elasticsearchversion byelasticsearch-modelis unnecessarily wide. (> 1)Also, the previous dependency of
> 1and the nonexistence of version-parameterized testmeans that the CI is not running against versions under 7.x. for
elasticsearch-model.I doubt the current code on
masterstill works for old versions,and I would like to avoid writing code to support compatibility on old versions on master branch.
To solve this issue, I have updated the dependency based on Elasticsearch gems' version policy.
This improves gem consistency and maintenance efficiency.
c.f.
https://github.com/elastic/elasticsearch-rails/tree/756a4dae1c51331a54bab8f00b0fcb88b4a480ad/elasticsearch-model#compatibility
#875