Skip to content

Use ContractJsonConverterAttribute where possible #3653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 12, 2019

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Apr 10, 2019

Use ContractJsonConverterAttribute where possible, and short-circuit JsonContract creation when a custom converter is found.

russcam added 5 commits April 10, 2019 12:13
This commit changes usage of JsonConverterAttribute to using
ContractJsonConverterAttribute where possible.
This commit updates the CreateContract method in ElasticContractResolver
to short-circuit if the type is attributed with ContractJsonConverterAttribute or
ExactContractJsonConverterAttribute. This avoids going through superfluous
steps in base.CreateContract().
@russcam russcam merged commit 044f557 into 6.x Apr 12, 2019
@Mpdreamz Mpdreamz deleted the enhancement/contract-converters branch June 17, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants