Skip to content

Update scroll.asciidoc #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2023
Merged

Update scroll.asciidoc #1763

merged 1 commit into from
May 11, 2023

Conversation

mabasic
Copy link
Contributor

@mabasic mabasic commented Sep 26, 2022

Should it not be scroll_id instead of scrollId? Typescript keeps complaining about this.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@mabasic
Copy link
Contributor Author

mabasic commented Oct 14, 2022

Anyone?

@JoshMock
Copy link
Member

jenkins test this

@JoshMock
Copy link
Member

@mabasic could you point this PR at main instead of 7.17? That way I can backport it to all branches with upcoming releases.

@mabasic mabasic changed the base branch from 7.17 to main May 10, 2023 16:28
@mabasic mabasic closed this May 10, 2023
@mabasic mabasic reopened this May 10, 2023
@mabasic
Copy link
Contributor Author

mabasic commented May 10, 2023

@mabasic could you point this PR at main instead of 7.17? That way I can backport it to all branches with upcoming releases.

Done. Hope it is good now.

@JoshMock
Copy link
Member

jenkins test this

@JoshMock JoshMock merged commit e73eef0 into elastic:main May 11, 2023
JoshMock pushed a commit that referenced this pull request May 11, 2023
JoshMock pushed a commit that referenced this pull request May 11, 2023
JoshMock pushed a commit that referenced this pull request May 11, 2023
JoshMock added a commit that referenced this pull request May 11, 2023
JoshMock added a commit that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants