-
Notifications
You must be signed in to change notification settings - Fork 195
Forward migrate action to endpoint #9801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward migrate action to endpoint #9801
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
internal/pkg/agent/application/actions/handlers/handler_action_migrate.go
Outdated
Show resolved
Hide resolved
internal/pkg/agent/application/actions/handlers/handler_action_migrate_test.go
Outdated
Show resolved
Hide resolved
This pull request is now in conflicts. Could you fix it? 🙏
|
just tested this with endpoint changes in place, we don't see ES failures anymore |
…ristas/elastic-agent into migrate/forward-migrate-endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for the CI to be green, but overall this LGTM
|
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* upstream: (505 commits) Update journald tests now that Filebeat supports watching folders (#10131) [deploy/kubernetes]: add info about hostPID for Universal Profiling (#10173) Fall back to process runtime if otel runtime is unsupported (#10087) Conditionall check for ms_tls13kdf build tag (#10160) [docs][edot] add entry for profiles (#10163) edot/docs: add support for profiles (#10146) Add Logstash exporter (#10137) Add back publish to serverless. (#10159) Improve Integration test documentation (#10155) Fix multiarch service image push from main to serverless (#10129) Forward migrate action to endpoint (#9801) Comment out check for ms_tls13kdf tag for FIPS-capable binaries (#10148) [otel] add receivers: apache, iis, mysql, postgresql, sqlserver v0.135.0 (#9344) Add k8sevents receiver in kube-stack (#10086) feat: emit system resource metrics for EDOT subprocess (#10003) [AutoOps] Configure OTel Exporter to Send Maximum-sized Batches (#10126) keep enrollment token when replacing data with signed (#10115) Revert "Publish `elastic-agent-service` container directly to serverless from main (#9583)" (#10127) Add agent_policy_id and policy_revision_idx to checkin requests (#9931) remove resource/k8s processor and use k8sattributes processor for service attributes (#10108) ...
Related issue is fixed on endpoint side and requires us to forward action to them.
Strategy here is to send MIGRATION action to them so they can prepare and update keys when new config arrives (after reenroll). without this they would consider new policy as untrustworthy
isMigrationInProgress
bool was added to coordinator for that purpose, we don't clear it to default value, migration is successful therefore we need to reexec very soon.Related: #9534