Skip to content

Enhancement/5235 upgrade cleanup after error #9250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 127 commits into from
Closed

Enhancement/5235 upgrade cleanup after error #9250

wants to merge 127 commits into from

Conversation

kaanyalti
Copy link

@kaanyalti kaanyalti commented Aug 4, 2025 •
edited
Loading

  • enhancement

What does this PR do?

This is a follow up to #9122

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

kaanyalti added 30 commits July 31, 2025 13:39
enhancement(5235): added disc space error function to respond to the …
8e5ac20 
…user with a clean disk space error, updated all necessary components to inject the error parsing function
enhancement(5235): updated error wrapping
f0a1bce
enhancement(5235): revert test timeout
c12f10e
enhancement(5235): added progress reporter test
daeaf92
enhancement(5235): added test for ReportFailed
7a2e118
enhancement(5235): created disk space error type, wrapping backoff pe…
ffc4ec0 
…rmanent error type
enhancement(5235): reverted downloader with retry changes
9d072f9
enhancement(5235): added insufficient disk space error type, moved er…
9f5c84a 
…ror conversion into the downloader for http downloader
enhancement(5235): updated insufficient disk error, removed backoff r…
eb915fb 
…elated wrapping. updated download with retries to wrap the error in permanent error if the error is insufficient disk error.
enhancement(5235): moved disk space error into its own package under …
c4aa985 
…upgrades. reverted constructor signature changes. updated tests
enhancement(5235): removed unnecessary error files
fd35453
enhancement(5235): added progress reporter interface in http download…
cebb42e 
…er, updated tests
enhancement(5235): updated tests
197ad8d
enhancement(5235): updated tests
5b7378f
enhancement(5235): added downloader factory provider and updated tests
5450532
enhancement(5235): updated progress reporter prepare function, fixed …
3d86720 
…cleanup for file downloader, added end-to-end tests for the upgrade manager upgrade function
enhancement(5235): refactored end to end upgrade tests to assert copy…
55c05e4 
… errors for file downloader and composed downloader
enhancement(5235): updated fs downloader download tests
9ba200d
enhancement(5235): added tests for progress reporter prepare
8362d11
enhancement(5235): removed unnecessary logging
dccf341
enhancement(5235): injecting details provider. added tests for settin…
901bdf4 
…g details provider, and end to end test to assert error messages correctly bubble up
enhancement(5235): ran mage check
7e18028
enhancement(5235): added changelog
54152f8
enhancment(5235): removed commented code
423839d
enhancement(5235): fix linting errors
0577d36
enhancement(5235): fix test cases
40e4485
enhancement(5235): updated tests, removed unused var
1d38805
enhancement(5235): updated progress reporter to avoid data race
961a86d
enhancement(5235): removed reference to embedded type
43e1f9d
enhancement(5235): returning path from download functions
f44e5a3
kaanyalti added 26 commits August 9, 2025 22:26
enhancement(5235): removed dev comment
6d5f508
enhancement(5235): using config to get os and arch instead of runtime
2fc7cfe
enhancmenet(5235): using config to get os and arch
5af449b
enhancement(5235): updated comment
6d923ce
enhancement(5235): added package level exported var for paths.Home() …
3c2dfb4 
…for testability
enhancement(5235): added package level vars for cop.Copy and os.Write…
ba288a1 
…File for testing
enhancement(5235): added function to check archive files are extracte…
07db133 
…d correctly using manifest and versioned home
enhancement(5235): added helper functions to create archives and adde…
29ec259 
…d action store error handling test
enhancement(5235): updated the use of archive helpers in unpack error…
e8b582d 
… handling tests
enhancement(5235): updated test function names
5e41094
enhancement(5235): use home path to get run path
9bef459
enhancement(5235): added run dir copy error test
8a1ee3c
enhancement(5235): refactored action store copy and run dir copy erro…
a9aaa6c 
…r tests
enhancement(5235): updated archive file modification functions
df1180e
enhancement(5235): using config target path for assertion
66e7864
enhancement(5235): added package symlink func to abstract os symlink
d58a4ad
enhancement(5235): removed unused var from function, regenerated mocks
cdba013
enhancement(5235): using homepath instead of home
5eced8d
enhancement(5235): update mock use in test
e66408a
enhancement(5235): added symlink error test
5267635
enhancement(5235): added mark upgrade error handling test
203a1a1
enhancement(5235): added diskspace error conversion
400b547
enhancement(5235): using writefile stub
8418253
enhancement(5235): added command exec package var in rollback
818994f
enhancement(5235): added release ugpradeable and context timeout pack…
64a6035 
…age vars for testing
enhancement(5235): added invoke wathcer and wait for watcher error ha…
b824ae6 
…ndling test cases
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 10, 2025 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

History

cc @kaanyalti

@elastic-sonarqube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
23.3% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube

@kaanyalti
Copy link
Author

Closing as this was an experimental PR

@kaanyalti kaanyalti closed this Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kaanyalti kaanyalti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaanyalti @elasticmachine