Compile the Windows archive proxy for the target GOARCH instead of the host GOARCH #11054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmacknz
changed the title
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
ycombinator
reviewed
Nov 7, 2025
ycombinator
previously approved these changes
Nov 7, 2025
Contributor
ycombinator
left a comment
ycombinator
left a comment
There was a problem hiding this comment.
Just a comment update, otherwise LGTM
Co-authored-by: Shaunak Kashyap <[email protected]>
Contributor
💛 Build succeeded, but was flaky
Failed CI Stepscc @cmacknz |
mergify bot
pushed a commit
that referenced
this pull request
Nov 13, 2025
…e host GOARCH (#11054) * Compile the archive proxy for the target GOARCH isntead of the host GOARCH. * Update comment to match function name. Co-authored-by: Shaunak Kashyap <[email protected]> --------- Co-authored-by: Shaunak Kashyap <[email protected]> (cherry picked from commit 318ad8f)
cmacknz
added
the
backport-active-9
Contributor
|
@Mergifyio backport 9.1 9.2 |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 14, 2025
…e host GOARCH (#11054) * Compile the archive proxy for the target GOARCH isntead of the host GOARCH. * Update comment to match function name. Co-authored-by: Shaunak Kashyap <[email protected]> --------- Co-authored-by: Shaunak Kashyap <[email protected]> (cherry picked from commit 318ad8f) # Conflicts: # magefile.go
cmacknz
added a commit
that referenced
this pull request
Nov 17, 2025
…e host GOARCH (#11054) (#11174) * Compile the archive proxy for the target GOARCH isntead of the host GOARCH. * Update comment to match function name. --------- (cherry picked from commit 318ad8f) Co-authored-by: Craig MacKenzie <[email protected]> Co-authored-by: Shaunak Kashyap <[email protected]> Co-authored-by: Eric Beahan <[email protected]>
hayotbisonai
pushed a commit
to hayotbisonai/elastic-agent
that referenced
this pull request
Nov 23, 2025
…e host GOARCH (elastic#11054) * Compile the archive proxy for the target GOARCH isntead of the host GOARCH. * Update comment to match function name. Co-authored-by: Shaunak Kashyap <[email protected]> --------- Co-authored-by: Shaunak Kashyap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When support for windows/arm builds was added in #9751 the Go archive proxy was switched from a fixed
amd64GOARCH to the host GOARCH. This works in CI which doesn't cross-compile for Windows but broke cross-compiling from darwin/arm64 to windows/amd64 for anyone on a Mac. This PR fixes that.To test: