[8.19] (backport #9392) Enhancement/5235 use disk space error to set upgrade detail in coordinator

[mergify]

PR 6/6

• Enhancement

What does this PR do?

• Updates the coordinator upgrade function.
  • If an upgrade fails with insufficient disk space error the coordinator sets the error to ErrInsufficientDiskSpaceError
• Addresses this comment Agent reports if there is insufficient disk space during upgrade, cleans up, and prevents upgrade #5235 (comment) in the parent issue

Why is it important?

• Disk space errors are not user friendly, so when the upgrade state shows the os disk space error the status output and the fleet ui gets cluttered.
• By setting the detail error to ErrInsufficientDiskSpaceError we are now providing a consistent and concise error message to the user.

Checklist

• I have read and understood the pull request guidelines of this project.
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• [ ] I have added an entry in ./changelog/fragments using the changelog tool
• [ ] I have added an integration test or an E2E test

Disruptive User Impact

none

How to test this PR locally

• Coordinator unit test is sufficient

Related issues

• Closes Agent reports if there is insufficient disk space during upgrade, cleans up, and prevents upgrade #5235
• Requires Enhancement/5235 upgrade cleans up downloads and extracted agent #9386

---

This is an automatic backport of pull request #9392 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of a7a76f6 has failed:

On branch mergify/bp/8.19/pr-9392
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit a7a76f6e1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   changelog/fragments/1757010848-agent-responds-with-clean-insufficient-disk-space-error-message.yaml
	modified:   internal/pkg/agent/application/coordinator/coordinator.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   internal/pkg/agent/application/coordinator/coordinator_unit_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[elasticmachine]

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

[mergify]

This pull request has not been merged yet. Could you please review and merge it @kaanyalti? 🙏

[ebeahan]

@kaanyalti can you take a look at this backport?

[elastic-sonarqube]

Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 74a1e90

Failed CI Steps

• Packaging: linux/arm64 tar.gz

History

• 💔 Build #27163 failed 9fe8d05

cc @kaanyalti