feat: replace global logging func with local logger #337
+15
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drop remaining usage of global logging funcs
kruskall
requested review from
faec and
mauri870
and removed request for
a team
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
|
Adding @khushijain21 as she already did a similar review on another of your PR (elastic/elastic-agent-system-metrics#254) |
khushijain21
reviewed
Aug 6, 2025
Co-authored-by: Khushi Jain <[email protected]>
|
The CI still fails :/ |
khushijain21
approved these changes
Aug 7, 2025
mauri870
approved these changes
Aug 7, 2025
|
buildkite test this |
💔 Build Failed
Failed CI StepsHistory
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
drop remaining usage of global logging funcs
Why is it important?
last remaining change to remove logp.{Info, Err, Warn, etc.} funcs
Checklist
Author's Checklist
Related issues