ci: use .java-version and prepare to use VM with installed tools in BK #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainJuge
reviewed
Mar 8, 2024
amannocci
previously approved these changes
Mar 8, 2024
Co-authored-by: SylvainJuge <[email protected]>
amannocci
previously approved these changes
Mar 8, 2024
SylvainJuge
previously approved these changes
Mar 8, 2024
| fi | ||
|
|
||
| echo "--- Release the binaries to Maven Central :maven: [./mvnw $GOAL)] $DRY_RUN_MSG" | ||
| ./mvnw -V -s .ci/settings.xml -Pgpg clean $GOAL -DskipTests --batch-mode | tee release.txt |
There was a problem hiding this comment.
Suggested change
| ./mvnw -V -s .ci/settings.xml -Pgpg clean $GOAL -DskipTests --batch-mode | tee release.txt | |
| ./mvnw -V -s .ci/settings.xml -Pgpg clean ${GOAL} -DskipTests --batch-mode | tee release.txt |
reakaleek
previously approved these changes
Mar 11, 2024
Co-authored-by: SylvainJuge <[email protected]>
|
run docs |
SylvainJuge
approved these changes
Mar 11, 2024
|
run docs build |
|
run docs-build rebuild |
1 similar comment
|
run docs-build rebuild |
|
run docs-build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
dry-runin the release/snapshot by default.Why
Follow-up
Test
Triggering manually against this particular feature branch (for such, I use the snapshot one):