Skip to content

Remove non-live versions from the drop downs #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Nov 22, 2019

Removes non-live versions from the version drop downs. We still publish
the non-live versions but we don't want to point folks to them
accidentally.

Closes #1431

Removes non-live versions from the version drop downs. We still publish
the non-live versions but we don't want to point folks to them
accidentally.

Closes elastic#1431
@nik9000
Copy link
Member Author

nik9000 commented Nov 22, 2019

@elasticmachine run elasticsearch-ci/docs rebuild

@nik9000
Copy link
Member Author

nik9000 commented Nov 22, 2019

I'm not convinced this'll look right, but I'm going to render it and have a look.

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :shipit:

@nik9000
Copy link
Member Author

nik9000 commented Nov 25, 2019

This seems to remove the version drop down everywhere. I wonder what is up!

@nik9000
Copy link
Member Author

nik9000 commented Nov 25, 2019

Hmmmm. The preview doesn't have the version in the drop down....

@nik9000
Copy link
Member Author

nik9000 commented Nov 25, 2019

I'd like #1457 to test this one.

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000
Copy link
Member Author

nik9000 commented Nov 27, 2019

@elasticmachine run elasticsearch-ci/docs rebuild

@nik9000
Copy link
Member Author

nik9000 commented Nov 27, 2019

OK! This doesn't look too bad, really. You can see it in action on an out of date page here and on an up to date page here.

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show only "live" versions in the version drop-down
4 participants