-
Notifications
You must be signed in to change notification settings - Fork 345
Remove non-live versions from the drop downs #1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removes non-live versions from the version drop downs. We still publish the non-live versions but we don't want to point folks to them accidentally. Closes elastic#1431
@elasticmachine run elasticsearch-ci/docs rebuild |
I'm not convinced this'll look right, but I'm going to render it and have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This seems to remove the version drop down everywhere. I wonder what is up! |
Hmmmm. The preview doesn't have the version in the drop down.... |
I'd like #1457 to test this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine run elasticsearch-ci/docs rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Removes non-live versions from the version drop downs. We still publish
the non-live versions but we don't want to point folks to them
accidentally.
Closes #1431