Add input-log4j to skiplist #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yaauie, please take a look and comment and/or review |
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input-log4j was deprecated in 5.x. Recent restructuring in Beats documentation caused broken links in log4j. It doesn't make sense to release a new gem to a deprecated plugin. Instead, this PR adds input-log4j to the skiplist so that we won't pick up deprecations that I have to reverse each time we generate the plugin docs.
Related: #45 #50
Note to self @karenzone and reviewer(s): This updates one of three skiplists, and I hope it will solve the log4j regression problems. Other skiplists:
ToDo: Dig into other skiplist to see how they relate and if we can do some cleanup to avoid confusion. Tracked in issue #50.