test: rework smoketests and improve usability

[kruskall]

always tee to tf.log
improve folder name and move smoketest under testing remove smokedir, we only have one smoketest
move function under smoketest

Closes #435

[lahsivjar]

Can we reuse https://github.com/elastic/apm-aws-lambda/tree/main/testing/tf-modules/lambda_deployment instead of having a separate custom module for smoketest?

[kruskall]

I'll open a followup for this so the ebpf team can pick it up

[v1v]

As far as I see these changes need to be reflected in the existing OIDC settings, otherwise:

Error: creating CloudWatch Logs Log Group (/aws/lambda/github-actions-smoke-testing-test): operation error CloudWatch Logs: CreateLogGroup, https response error StatusCode: 400, RequestID: a8b0d29f-46bb-4427-aef0-c0fe1c3ae0b9, api error AccessDeniedException: User: arn:aws:sts::697149045717:assumed-role/gha-55ef6f9ad3e07084a079d653f88b25e629e0812c646a890bd344605-role/GitHubActions is not authorized to perform: logs:CreateLogGroup on resource: arn:aws:logs:eu-central-1:697149045717:log-group:/aws/lambda/github-actions-smoke-testing-test:log-stream: because no identity-based policy allows the logs:CreateLogGroup action

  with aws_cloudwatch_log_group.example,
  on main.tf line 105, in resource "aws_cloudwatch_log_group" "example":
 105: resource "aws_cloudwatch_log_group" "example" {


Error: creating IAM Policy (smoketest_extension_lambda_logging): operation error IAM: CreatePolicy, https response error StatusCode: 403, RequestID: 14eaa9ba-a9f1-4cbc-b943-d2413df9cd8e, api error AccessDenied: User: arn:aws:sts::697149045717:assumed-role/gha-55ef6f9ad3e07084a079d653f88b25e629e0812c646a890bd344605-role/GitHubActions is not authorized to perform: iam:CreatePolicy on resource: policy smoketest_extension_lambda_logging because no identity-based policy allows the iam:CreatePolicy action

  with aws_iam_policy.lambda_logging,
  on main.tf line 124, in resource "aws_iam_policy" "lambda_logging":
 124: resource "aws_iam_policy" "lambda_logging" {

Error: Terraform exited with code 1.
-> Calling the lambda function...

An error occurred (AccessDeniedException) when calling the Invoke operation: User: arn:aws:sts::697149045717:assumed-role/gha-55ef6f9ad3e07084a079d653f88b25e629e0812c646a890bd344605-role/GitHubActions is not authorized to perform: lambda:InvokeFunction on resource: arn:aws:lambda:eu-central-1:697149045717:function:github-actions-smoke-testing-test because no identity-based policy allows the lambda:InvokeFunction action

I'm gonna fix this

[rockdaboot]

@v1v See also #526