-
Notifications
You must be signed in to change notification settings - Fork 32
Agent-server comm options are not applicable to AWS lambda extension #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/monitoring-aws-lambda.asciidoc
Outdated
Note that not all APM agent configuration options are supported by the {apm-lambda-ext}. | ||
For example, configuration variables like `verify_server_cert`, `server_cert`, and `use_certifi` are not supported as they configure | ||
how an Elastic APM agent interacts with the APM Server. The {apm-lambda-ext} communicates with the APM agent, not the APM Server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: I'm not sure I understand this statement. The APM agent configuration options apply to the apm agent while the lambda extension uses the lambda configuration options. As an example, we have ELASTIC_APM_LAMBDA_VERIFY_SERVER_CERT
to enable/disable certificate validation for the lambda extension.
I don't think this is about the lambda extension not supporting APM agent configuration options (it never did) but more like some APM agent configuration options not "making sense" when the agent is running in a lambda environment.
The {apm-lambda-ext} communicates with the APM agent, not the APM Server.
Could you clarify this ? The lambda extension acts as a proxy between the agent and the apm server. The flow is: agent -> lambda extension -> apm server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that helps. What do you think of the new wording?
…lastic#403) * Update monitoring-aws-lambda.asciidoc * Update monitoring-aws-lambda.asciidoc (cherry picked from commit 3d7aab7)
…lastic#403) * Update monitoring-aws-lambda.asciidoc * Update monitoring-aws-lambda.asciidoc (cherry picked from commit 3d7aab7)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Summary
I'm not sure that what I'm writing here is correct. Can someone please double-check? This PR is based on the information explained in #349.
Tagging @lahsivjar and @kruskall for review as you're the last two people to touch this file. Please feel free to ping others if you're not the correct reviewers.
Next steps
If this PR is correct and can be merged, I'll manually backport the changes to 8.10 and 8.9.