Skip to content

Agent-server comm options are not applicable to AWS lambda extension #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

bmorelli25
Copy link
Member

Summary

I'm not sure that what I'm writing here is correct. Can someone please double-check? This PR is based on the information explained in #349.

Tagging @lahsivjar and @kruskall for review as you're the last two people to touch this file. Please feel free to ping others if you're not the correct reviewers.

Next steps

If this PR is correct and can be merged, I'll manually backport the changes to 8.10 and 8.9.

@bmorelli25 bmorelli25 self-assigned this Sep 5, 2023
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Sep 5, 2023
Comment on lines 68 to 70
Note that not all APM agent configuration options are supported by the {apm-lambda-ext}.
For example, configuration variables like `verify_server_cert`, `server_cert`, and `use_certifi` are not supported as they configure
how an Elastic APM agent interacts with the APM Server. The {apm-lambda-ext} communicates with the APM agent, not the APM Server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: I'm not sure I understand this statement. The APM agent configuration options apply to the apm agent while the lambda extension uses the lambda configuration options. As an example, we have ELASTIC_APM_LAMBDA_VERIFY_SERVER_CERT to enable/disable certificate validation for the lambda extension.

I don't think this is about the lambda extension not supporting APM agent configuration options (it never did) but more like some APM agent configuration options not "making sense" when the agent is running in a lambda environment.

The {apm-lambda-ext} communicates with the APM agent, not the APM Server.

Could you clarify this ? The lambda extension acts as a proxy between the agent and the apm server. The flow is: agent -> lambda extension -> apm server

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that helps. What do you think of the new wording?

@bmorelli25 bmorelli25 merged commit 3d7aab7 into main Sep 7, 2023
@bmorelli25 bmorelli25 deleted the bmorelli25-patch-1 branch September 7, 2023 16:43
bmorelli25 added a commit to bmorelli25/apm-aws-lambda that referenced this pull request Sep 7, 2023
…lastic#403)

* Update monitoring-aws-lambda.asciidoc

* Update monitoring-aws-lambda.asciidoc

(cherry picked from commit 3d7aab7)
bmorelli25 added a commit to bmorelli25/apm-aws-lambda that referenced this pull request Sep 7, 2023
…lastic#403)

* Update monitoring-aws-lambda.asciidoc

* Update monitoring-aws-lambda.asciidoc

(cherry picked from commit 3d7aab7)
@bmorelli25
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.9
8.10

Questions ?

Please refer to the Backport tool documentation

bmorelli25 added a commit that referenced this pull request Sep 7, 2023
…403) (#406)

* Update monitoring-aws-lambda.asciidoc

* Update monitoring-aws-lambda.asciidoc

(cherry picked from commit 3d7aab7)
bmorelli25 added a commit that referenced this pull request Sep 7, 2023
…403) (#405)

* Update monitoring-aws-lambda.asciidoc

* Update monitoring-aws-lambda.asciidoc

(cherry picked from commit 3d7aab7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

document agent-server communication options are not applicable to AWS lambda extension
2 participants