Skip to content

Rename CreateProxyTxn to MaybeCreateProxyTxn #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2023
Merged

Rename CreateProxyTxn to MaybeCreateProxyTxn #388

merged 1 commit into from
Apr 27, 2023

Conversation

lahsivjar
Copy link
Contributor

Renames CreateProxyTxn to MaybeCreateProxyTxn as it better represents what the function does. A proxy transaction will be created only if it is needed. A proxy transaction will be needed if:

  1. A transaction with the same transaction.id as the one registered during agent init is not reported by the agent.
  2. An invocation has already been finalized before.
  3. Transaction hasn't been successfully registered during agent init.

@lahsivjar lahsivjar requested a review from axw April 26, 2023 01:03
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Apr 26, 2023
@lahsivjar lahsivjar mentioned this pull request Apr 26, 2023
Closed
@lahsivjar lahsivjar merged commit cf9f5a3 into elastic:main Apr 27, 2023
@lahsivjar lahsivjar deleted the minor-refactor branch April 27, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

Assignees
No one assigned
Labels
aws-λ-extension AWS Lambda Extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahsivjar @axw