fix test result output on Windows #951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `call` swallows the exit code of the test runner, making Jenkins mark failed test runs as unstable instead of failed.
💚 Flaky test reportTests succeeded. Test stats 🧪
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* fix test result output on Windows Using `call` swallows the exit code of the test runner, making Jenkins mark failed test runs as unstable instead of failed. * exit if pytest fails * set error code explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
callswallows the exit code of the test runner, makingJenkins mark failed test runs as unstable instead of failed.