More py3.12 CI fixup #1917
Merged
More py3.12 CI fixup #1917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test appeared to be causing a segfault in py3.12, perhaps due to being short-lived (as it wasn't waiting for anything to be sent to the sending_elasticapm_client, or closing it). It didn't actually need the sending version, so hopefully this fixes that issue 🤞
trentm
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to non-sending client fixture in
test_grpc_client_max_spans. The test appeared to be causing a flakey segfault in py3.12, perhaps due to the client being short-lived (as it wasn't waiting for anything to be sent to the sending_elasticapm_client, or closing it in-test). It didn't actually need the sending version, so hopefully this fixes that issue 🤞