Skip to content

make sure Starlette's make_apm_client works without providing a config dict #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2021
Merged

make sure Starlette's make_apm_client works without providing a config dict #1161

merged 2 commits into from
Jun 10, 2021

Conversation

beniwohli
Copy link
Contributor

closes #1160

@beniwohli beniwohli requested a review from basepi June 9, 2021 15:02
@beniwohli beniwohli mentioned this pull request Jun 9, 2021
Closed
@ghost
Copy link

ghost commented Jun 9, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1161 opened

  • Start Time: 2021-06-09T15:02:45.434+0000

  • Duration: 28 min 41 sec

  • Commit: 9f47969

Test stats 🧪

Test Results
Failed 0
Passed 9513
Skipped 8766
Total 18279

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9513
Skipped 8766
Total 18279

@beniwohli beniwohli merged commit ab0f439 into elastic:master Jun 10, 2021
@beniwohli beniwohli deleted the fix-1160 branch June 10, 2021 08:00
beniwohli added a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
@beniwohli
make sure Starlette's make_apm_client works without providing a confi…
25710bc 
…g dict (elastic#1161)

closes elastic#1160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basepi basepi basepi approved these changes

Assignees
No one assigned
Labels
agent-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Starlette/FastAPI python agent setup examples result in TypeError
2 participants
@beniwohli @basepi