Skip to content

Add code snippet to fix Asciidoctor link #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2019
Merged

Add code snippet to fix Asciidoctor link #923

merged 2 commits into from
Mar 15, 2019

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 self-assigned this Mar 15, 2019
@bmorelli25 bmorelli25 requested review from watson and Qard March 15, 2019 18:03
@bmorelli25 bmorelli25 force-pushed the fix-asciidoctor-errors branch from 12af705 to 87bb27e Compare March 15, 2019 18:10
nik9000
nik9000 approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I don't know that I'm the right person to review code in this repo.

nik9000
nik9000 suggested changes Mar 15, 2019
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this doesn't render right for me in Asciidoctor. I think this may be a thing where Asciidoctor and AsciiDoc are just incompatible. i think it is OK because it is fairly rare.

@bmorelli25
Copy link
Member Author

Ahh crap you're right. I tested it with asciidoc on accident 🤦‍♂️

@bmorelli25
Copy link
Member Author

Alright, just removed the link text.

nik9000
nik9000 approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@watson
Copy link
Contributor

watson commented Mar 15, 2019

There seem to be some issues with the tests on the 1.x branch. This is unrelated to docs and those build fine, so I'll just merge it anyway.

@watson watson merged commit e757d1b into elastic:1.x Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qard Qard Awaiting requested review from Qard

2 more reviewers

@watson watson watson approved these changes

@nik9000 nik9000 nik9000 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@bmorelli25 bmorelli25

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmorelli25 @watson @nik9000