-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Added AL2023 support for Outpost nodes #8591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
AL2 is on deprecation path, making AL2023 the only supported operating system for node-groups on Outpost. Using AL2 will now cause validation error. Leaving the AL2 code in place, to be deleted after this OS is officially deprecated.
|
Hello nkvetsinski 👋 Thank you for opening a Pull Request in |
| github.com/aws/aws-sdk-go-v2/config v1.31.12 | ||
| github.com/aws/aws-sdk-go-v2/credentials v1.18.21 | ||
| github.com/aws/aws-sdk-go-v2/service/autoscaling v1.60.4 | ||
| github.com/aws/aws-sdk-go-v2/service/cloudformation v1.68.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
causing a build failure, not sure if you need to rebase / can also leave off the generated changes
https://github.com/eksctl-io/eksctl/actions/runs/19619569203/job/56388775476?pr=8591
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try to rebase
| } | ||
| if controlPlaneOnOutposts && ng.AMIFamily != NodeImageFamilyAmazonLinux2 { | ||
| return fmt.Errorf("only %s is supported on local clusters", NodeImageFamilyAmazonLinux2) | ||
| if controlPlaneOnOutposts && ng.AMIFamily != NodeImageFamilyAmazonLinux2023 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much context on this feature but just creating an AL2 node we only log a warning and still let users create it if they explicitly try to.
Are we worried about breaking customers who may rely on AL2 and aren't ready to migrate yet? Just calling this out explicitly so if that is the intention that is fine too.
If this is the intention can we be more clear in the PR title that you can no longer create AL2 outpost clusters (will get added to release notes)
Description
AL2 is on deprecation path, making AL2023 the only supported operating
system for node-groups on Outpost. Using AL2 will now cause validation
error. Leaving the AL2 code in place, to be deleted after this OS is
officially deprecated.
Some mocks/dependencies got updated too, I'm including them in the PR, not sure if that's how you guys do it.
Checklist
README.md, or theuserdocsdirectory) (kind of)area/nodegroup) and kind (e.g.kind/improvement)Testing
Created a cluster on real outpost. Then added a node using the following command:
The node failed joining initially, because of a bug in the DescribeCluster EKS API for the outpost use case. We return the port for the cluster endpoint (see below), which causes
nodeadmto fail resolving the cluster endpoint DNS. In order to do the end-to-end test, I sanitized the endpoint and the node was able to join.I decided to fix the EKS API, instead of sanitizing the DescribeCluster output in
eksctl.BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯