Build binaries again through PHONY Makefile targets #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
989-back-to-phony-targets
branch
from
2887009 to
b59e3d1
Compare
Golang is good at computing explicit dependencies, there wasn't really a reason to re-invent the wheel (computing the dependencies took as long as invoking Golang). However, we continue to compute and use the non-explicit dependencies (generated code) as Make recipe prerequisites. This gives us the best of both worlds, while also reducing the time for `make` to read the Makefile (speeding up things like autocompletion) and adding fresh compile-time provided symbols (e.g. git commit hash) in every build.
2opremio
force-pushed
the
989-back-to-phony-targets
branch
from
b59e3d1 to
ea6fc1d
Compare
errordeveloper
approved these changes
Jul 11, 2019
gemagomez
pushed a commit
that referenced
this pull request
Jul 17, 2019
This problem was introduced in PR #1014
errordeveloper
pushed a commit
that referenced
this pull request
Jul 19, 2019
This problem was introduced in PR #1014
errordeveloper
pushed a commit
that referenced
this pull request
Jul 19, 2019
This problem was introduced in PR #1014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang is good at computing explicit dependencies, there wasn't really
a reason to re-invent the wheel (computing the dependencies took as long
as invoking the compiler).
However, we continue to compute and use the non-explicit dependencies (generated
code) as Make recipe prerequisites.
This gives us the best of both worlds, while also reducing the time for
maketo read the Makefile (speeding up things like autocompletion) and adding fresh
compile-time provided symbols (e.g. git commit hash) in every build.
Fixes #989 (which was introduced in #944 )