feat: update most MFE configs to elm-theme #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
PARAGON_BRAND_PACKAGEfield for most of our MFE services. This field is used when bringing up the service to determine what the@edx/brandpackage should be aliased to.By default, the
@edx/brandpackage is aliased to the open source brand (@openedx/brand-openedx). In our Stage and Production environments, we alias the package to point to the private 2u/edX theme. Previously this was@edx/brand-edx.org— the old theme. We have now switched to@edx/elm-theme— the new theme. The old theme does not support design tokens, which were introduced in Paragon v23 as the method for theming Paragon components. Without a brand package that provides design tokens, MFE builds will fail if they are using the latest code from master branches. Elm theme supports design tokens.All master branches of the Open edX supported MFEs have been updated to Paragon v23 and now require design token support from the brand package.
It is worth noting that the configuration for 4 MFEs has been left unchanged in this PR. They are:
Until the forked repositories have been upgraded to Paragon v23 and have support for design tokens, the configuration can not be changed. Dev builds would fail if we try to use
@edx/elm-themewithout that support.Testing instructions
make dev.remove-containers.frontend-app-learner-dashboardto bring down the service (if it's already running)make dev.up.frontend-app-learner-dashboardIf you want to test what it looked like before
You can either:
OR
PARAGON_BRAND_PACKAGEand instead set it to@edx/[email protected]THEN,
make dev.remove-containers.frontend-app-learner-dashboard)make dev.remove-containers.frontend-app-learner-dashboard)I've completed each of the following or determined they are not applicable: