fix: make edx-themes provisioning respect $DEVSTACK_WORKSPACE #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, make cloning less likely to stall automated provisioning.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the edX themes are provisioned correctly, respecting the DEVSTACK_WORKSPACE environment variable and reducing the chance of cloning stalling automated provisioning.
- Changes to use separate SSH and HTTPS repository URLs for cloning
- Directory creation now uses the DEVSTACK_WORKSPACE path for the src directory
- Uses pushd/popd for improved directory management during cloning
brobro10000
approved these changes
May 12, 2025
adamstankiewicz
approved these changes
May 12, 2025
Contributor
adamstankiewicz
left a comment
adamstankiewicz
left a comment
There was a problem hiding this comment.
Seems reasonable, though I'm not too familiar with the pushd and popd syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, make cloning less likely to stall automated provisioning.