Osama/add hawthorn support #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubair-arbi
suggested changes
May 21, 2019
|
|
||
| ``` | ||
| $ export OPENEDX_RELEASE=ironwood.master | ||
| export OPENEDX_RELEASE=ironwood.master |
There was a problem hiding this comment.
I would suggest pinning the OPENEDX_RELEASE to named release tags instead of just pointing the head to master. https://edx.readthedocs.io/projects/edx-developer-docs/en/latest/named_releases.html#ironwood
There was a problem hiding this comment.
Well, that isn't how the devstack processes Open edX repos. It needs a dedicated branch to be able to properly clone and checkout repos.
|
to be very honest. those hacks will cause many devstack issues. |
Ayub-Khan
approved these changes
May 21, 2019
zubair-arbi
approved these changes
May 21, 2019
asamolion
added a commit
that referenced
this pull request
May 21, 2019
# This is the 1st commit message: ADD: add clone feature for edly wp repos # The commit message #2 will be skipped: # ADD: add wordpress clone support # The commit message #3 will be skipped: # WIP: add WP container # The commit message #4 will be skipped: # ADD: add config for wordpress plugins, themes and env # The commit message #5 will be skipped: # MOD: refine the config for WP container # The commit message #6 will be skipped: # ADD: add custom build script for edly/wp docker image # The commit message #7 will be skipped: # FIX: remove unnecessary keys # The commit message #8 will be skipped: # FIX: add correct settings in wp-config.php # The commit message #9 will be skipped: # MOD: add custom config for WP image # The commit message #10 will be skipped: # FIX: use proper docker image # The commit message #11 will be skipped: # ADD: add must install wp plugins # The commit message #12 will be skipped: # FIX: fix version of wordpress docker image
asamolion
added a commit
that referenced
this pull request
May 22, 2019
# This is the 1st commit message: ADD: add clone feature for edly wp repos # The commit message #2 will be skipped: # ADD: add wordpress clone support # The commit message #3 will be skipped: # WIP: add WP container # The commit message #4 will be skipped: # ADD: add config for wordpress plugins, themes and env # The commit message #5 will be skipped: # MOD: refine the config for WP container # The commit message #6 will be skipped: # ADD: add custom build script for edly/wp docker image # The commit message #7 will be skipped: # FIX: remove unnecessary keys # The commit message #8 will be skipped: # FIX: add correct settings in wp-config.php # The commit message #9 will be skipped: # MOD: add custom config for WP image # The commit message #10 will be skipped: # FIX: use proper docker image # The commit message #11 will be skipped: # ADD: add must install wp plugins # The commit message #12 will be skipped: # FIX: fix version of wordpress docker image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.