Upgrade React Router to v6.x #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a whole bunch of changes here, but most revolve around converting small components to function components or wrapping more complex ones in function components, since v6 has embraced hooks wholesale, and there's not another way to do a lot of fundamental things anymore. Part of #1082, obsoletes #1035.
I think I went a little too far in the last commit, putting all the URL params directly on the component as individual props. This keeps them together as a single `urlParams` prop, which I think is a little better organized.
19 tasks
Mr0grog
added a commit
that referenced
this pull request
Sep 16, 2025
During our React Router v6 upgrade (#1099), I unintentionally created a situation where the search bar owuld be blown away and its state (and your current query) would be lost when the search actually runs and results are shown. This solves the issue, although it takes some hacky code and makes it hackier still. :(
Mr0grog
added a commit
that referenced
this pull request
Sep 16, 2025
During our React Router v6 upgrade (#1099), I unintentionally created a situation where the search bar owuld be blown away and its state (and your current query) would be lost when the search actually runs and results are shown. This solves the issue, although it takes some hacky code and makes it hackier still. :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a whole bunch of changes here, but most revolve around converting small components to function components or wrapping more complex ones in function components, since v6 has embraced hooks wholesale, and there's not another way to do a lot of fundamental things anymore.
Part of #1082, obsoletes #1035.