Clean up some warnings #1315
Merged
Clean up some warnings #1315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a few random warnings that have been floating around for a while. Not really a huge deal: - Add `pstore` to the bundle. TBH I think this warning would otherwise just go away when pstore stops being bundled with Ruby but yaml still is, but I'm tired of seeing this warning. - Opt-in to frozen string literals in a test that was triggering warnings about them. Nothing about the test is really changing, though. As far as I can tell, Rails test requests pass string values for POST bodies directly on to Rack's mock request, which then tries to set the string's encoding, which causes the warning. I guess it does not do so if the string is frozen, though.
Should have done this long ago!
Member
Author
Went ahead and actually did this. Long overdue. THE FUTURE IS HERE! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a couple random warnings that have been floating around for a while. None are really a huge deal AFAICT:
Add
pstoreto the bundle. TBH I think this warning would otherwise just go away when pstore stops being bundled with Ruby and yaml still is (I assume the bundled yaml gem will have to stop referencing it? idunno what the plan here is), but I'm tired of seeing this warning.Opt-in to frozen string literals in a test that was triggering warnings about them. Nothing about the test is really changing, though. As far as I can tell, Rails test requests pass string values for POST bodies directly on to Rack's
mock_request, which then tries to set the string's encoding, which causes the warning. I guess it does not do so if the string is frozen, though.Really I should probably just add this
frozen_string_literaldirective to every Ruby file…