Skip to content

Add transaction accessor in Connection #646 #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add transaction accessor in Connection #646 #647

wants to merge 1 commit into from

Conversation

FroMage
Copy link

@FroMage FroMage commented May 20, 2020

Fixes #646

@vietj
Copy link
Member

vietj commented May 20, 2020

@FroMage you need to sign your commit

@BillyYccc
Copy link
Member

Note after a transaction is opened, the tx field is set to null only when the connection gets the response of COMMIT or ROLLBACK. I'm not sure it will reflect the transaction state correctly in command pipelining mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add transaction accessor in Connection
3 participants
@FroMage @vietj @BillyYccc